Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Add check for go mod tidy #183

Merged
merged 2 commits into from
Aug 28, 2024
Merged

feat(ci): Add check for go mod tidy #183

merged 2 commits into from
Aug 28, 2024

Conversation

jonstacks
Copy link
Contributor

Supersedes #182

Adds a check to make sure that go mod tidy produces no diff for the go.mod or go.sum files.

Also updates some of our actions versions while we are here.

@jonstacks jonstacks self-assigned this Aug 28, 2024
@jonstacks jonstacks marked this pull request as ready for review August 28, 2024 06:12
@jonstacks
Copy link
Contributor Author

Validation can be seen in the first commit for adding the new check. go.mod wasn't tidy and so the added check fails. We fix it in the second commit.

@jonstacks jonstacks requested a review from a team August 28, 2024 16:08
Copy link
Contributor

@nikolay-ngrok nikolay-ngrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jonstacks jonstacks merged commit e765b00 into main Aug 28, 2024
2 checks passed
@jonstacks jonstacks deleted the add-go-mod-tidy-check branch August 28, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants