plumb url into structures needed for agent #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed37d97 to
b4ccdf1
Compare
f0f877d to
71c0440
Compare
nikolay-ngrok
approved these changes
Jul 17, 2024
71c0440 to
bf547bd
Compare
Megalonia
approved these changes
Jul 17, 2024
a9d5938 to
7a7f835
Compare
add deprecation notice later
96fca4b to
887e2f4
Compare
|
Holding off now that I've found a workaround that won't require me to bump up the version. Instead I can wait and do an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to https://github.com/ngrok-private/ngrok/pull/31396.
See thread for background context
Background: I was originally going to do a version release towards the end of my work, but I figured that since we already have a breaking change that needs fixing, I might as well include my plumbing code to avoid two back-to-back releases.