-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple session legs support #158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b56247
to
90c99c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me! Some public API nits, but overall looks good 👍
OfTheDelmer
reviewed
Feb 27, 2024
c5699e0
to
83880e3
Compare
jrobsonchase
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for multiple session legs.
This adds two configuration options:
WithAdditionalServers(addrs []string)
WithMultiLeg(enable bool)
If multi-leg is enabled, then the
ConnectAddresses
in the Auth response of the first session are used to determine what additional sessions should be set up. TheReconnectingSession
will accumulate more sessions on connect, then return as normal.ReconnectionSession
will handle fan-out of calls to the underlyingtunnel_client.Session
as before, except now there are multiple of them.If the first connection is made using least-latency, it will lock in to that
ConnectAddress
so reconnects will go back to the same region. Heartbeat callbacks are done for each underlying session, including appropriate region and latency information.