Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #41 and #50 #51

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Fix for #41 and #50 #51

merged 2 commits into from
Oct 26, 2023

Conversation

mtb0x1
Copy link
Contributor

@mtb0x1 mtb0x1 commented Oct 25, 2023

Proposed changes

This PR include a fix for the issues below:

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ivanitskiy
Copy link
Contributor

@mtb0x1 LGTM. Could you please squash zlib-related commits (0e68c42 and a212649) into one? then I can make a new nginx-sys crate version and upload to crates.io with those fixes.

@mtb0x1
Copy link
Contributor Author

mtb0x1 commented Oct 26, 2023

@ivanitskiy : done.

@ivanitskiy ivanitskiy merged commit 8706830 into nginx:master Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants