CP/DP split: update/delete user secrets #3193
Open
+661
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aab4411 to
afa658a
Compare
Problem: When a user updates or deletes their docker registry or NGINX Plus secrets, those changes need to be propagated to all duplicate secrets that we've provisioned for the Gateway resources. Solution: If updated, update the provisioned secret. If deleted, delete the provisioned secret.
84e1e4b to
a076855
Compare
bjee19
reviewed
Mar 4, 2025
| return false | ||
| } | ||
|
|
||
| func (p *NginxProvisioner) deleteSecret(ctx context.Context, secretNSName types.NamespacedName) error { |
There was a problem hiding this comment.
Did you consider adding a leader check here? Is it necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When a user updates or deletes their docker registry or NGINX Plus secrets, those changes need to be propagated to all duplicate secrets that we've provisioned for the Gateway resources.
Solution: If updated, update the provisioned secret. If deleted, delete the provisioned secret.
Testing: Verified that when a special Secret is updated, the provisioned Secret is also updated. When the special Secret is deleted, the provisioned Secret is deleted.
Closes #2845