-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closing modal with ESC is interrupted by datepicker #3358
Milestone
Comments
maxokorokov
added a commit
to maxokorokov/ng-bootstrap
that referenced
this issue
Sep 20, 2019
At the moment the focus is lost, so it will be restored to the previously focused element (before datepicker was opened) Fixes ng-bootstrap#3317 Fixes ng-bootstrap#3358
maxokorokov
added a commit
to maxokorokov/ng-bootstrap
that referenced
this issue
Sep 20, 2019
At the moment the focus is lost, so it will be restored to the previously focused element (before datepicker was opened) Fixes ng-bootstrap#3317 Fixes ng-bootstrap#3358
maxokorokov
added a commit
to maxokorokov/ng-bootstrap
that referenced
this issue
Sep 27, 2019
Fixes an issue for datepicker, typeahead, dropdown inside the modal. When these components are closed on ESC, modal stays open. Fixes ng-bootstrap#3358
maxokorokov
added a commit
to maxokorokov/ng-bootstrap
that referenced
this issue
Sep 27, 2019
Fixes an issue for datepicker, typeahead, dropdown inside the modal. When these components are closed on ESC, modal stays open. Fixes ng-bootstrap#3358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description:
If there is a datepicker component with an overlay, which uses ESC key within parent modal, also with ESC key feature enabled, opening the datepicker and then closing it with ESC, disabled effectively the ESC feature on the container modal, requiring user to perform additional action to refocus any content within modal.
This is probably related to: #3317
This could be repeated with default demo content:
https://stackblitz.com/run?file=app/modal-basic.ts
https://ng-bootstrap.github.io/#/components/modal/examples#basic
Link to minimally-working StackBlitz that reproduces the issue:
As stated, this is repeatable with demo content:
https://ng-bootstrap.github.io/#/components/modal/examples#basic
Versions of Angular, ng-bootstrap and Bootstrap:
Angular: n/a
ng-bootstrap:
5.1.1
Bootstrap:
n/a
The text was updated successfully, but these errors were encountered: