Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ipfs URL to gateway URL converter #161

Merged
merged 6 commits into from
Jun 1, 2021

Conversation

alanshaw
Copy link
Contributor

@alanshaw alanshaw commented May 27, 2021

Adds a function that converts ipfs://bafy... URLs to gateway URLs like https://dweb.link/ipfs/bafy...

resolves #158

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 27, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f31be3f
Status: ✅  Deploy successful!
Preview URL: https://fb0649c6.nft-storage.pages.dev

View logs

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #161 (55541c3) into main (45fc9d4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #161   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         5    +1     
  Lines          678       696   +18     
=========================================
+ Hits           678       696   +18     
Impacted Files Coverage Δ
src/lib.js 100.00% <0.00%> (ø)
src/token.js 100.00% <0.00%> (ø)
src/embed.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45fc9d4...55541c3. Read the comment docs.

packages/client/src/embed.js Outdated Show resolved Hide resolved
packages/client/test/embed.spec.js Outdated Show resolved Hide resolved
packages/client/package.json Show resolved Hide resolved
Copy link
Contributor

@hugomrdias hugomrdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanshaw alanshaw merged commit f115cd8 into main Jun 1, 2021
@alanshaw alanshaw deleted the feat/ipfs-to-gateway-url-converter branch June 1, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose ipfs:// -> gateway URL converter in client
4 participants