Skip to content

Commit

Permalink
Remove outer function wrapper (tensorflow#889)
Browse files Browse the repository at this point in the history
We remove the outer function wrapper from the default value for xComponentsCreationMethod because `vz_line_chart.stepX` is already a valid value for the property.

Creating a function that returns `vz_line_chart.stepX` results in a bug.
  • Loading branch information
chihuahua authored and nfelt committed Feb 6, 2018
1 parent dfac0e7 commit 8002538
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tensorboard/components/vz_line_chart/vz-line-chart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ Polymer({
_attached) {
// Find the actual xComponentsCreationMethod.
if (!xType && !xComponentsCreationMethod) {
xComponentsCreationMethod = () => vz_line_chart.stepX;
xComponentsCreationMethod = vz_line_chart.stepX;
} else if (xType) {
xComponentsCreationMethod = () =>
vz_line_chart.getXComponents(xType);
Expand Down

0 comments on commit 8002538

Please sign in to comment.