Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PortalStudy.json #534

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Update PortalStudy.json #534

merged 3 commits into from
Oct 22, 2024

Conversation

cconrad8
Copy link
Contributor

No description provided.

@cconrad8
Copy link
Contributor Author

cconrad8 commented Oct 21, 2024

This is related to this PR as well - nf-osi/jobs#90 and this ticket
https://github.com/orgs/nf-osi/projects/3/views/1?pane=issue&itemId=61481556&issue=nf-osi%7Cnf-metadata-dictionary%7C459

@nf-osi/dcc-team

I think the main issue we need to solve is having a discrepancy between grant end and embargo dates/ closeout of projects in Synpase tables vs. Github - and this could be a first step.

@cconrad8 cconrad8 requested a review from anngvu October 21, 2024 21:13
Copy link

github-actions bot commented Oct 22, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-22 15:54 UTC

Copy link
Collaborator

@anngvu anngvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cconrad8 Thanks, we can merge this first. Note: Remember to update the YAML directly since the JSON is just like the JSON-LD (generated from the YAML).

@anngvu anngvu merged commit 608e06b into main Oct 22, 2024
@anngvu anngvu deleted the add-grant-dates branch October 22, 2024 15:53
@cconrad8
Copy link
Contributor Author

oops! thank you for the reminder! @anngvu

Copy link

Test Suite Report 24.7.2

Template Generation

template result link
ClinicalAssayTemplate 😄 template link
EpigeneticsAssayTemplate 😄 template link
FlowCytometryTemplate 😄 template link
GenomicsAssayTemplate 😄 template link
GenomicsAssayTemplateExtended 😄 template link
HumanCohortTemplate
ImagingAssayTemplate 😄 template link
LightScatteringAssayTemplate 😄 template link
MethylationArrayTemplate 😄 template link
MRIAssayTemplate 😄 template link
PharmacokineticsAssayTemplate 😄 template link
PlateBasedReporterAssayTemplate 😄 template link
ProcessedAlignedReadsTemplate 😄 template link
ProcessedExpressionTemplate 😄 template link
ProcessedVariantCallsTemplate 😄 template link
ProteomicsAssayTemplate 😄 template link
ProtocolTemplate 😄 template link
RNASeqTemplate 😄 template link
ScRNASeqTemplate 😄 template link
UpdateMilestoneReport 😄 template link
WESTemplate 😄 template link
WGSTemplate 😄 template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv 😄 Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv 😄 Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv 😄 Conditional validation for attributes is currently not supported
GenomicsAssayTemplate_control.csv 😄 There should be no issue with this template.
ScRNASeqTemplate_0.csv 😄 Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv 😄 Fail because of missing data in required field libraryStrand

Manifest Submission

manifest pass
GenomicsAssayTemplate_0.csv 😄
GenomicsAssayTemplate_1.csv 😄
GenomicsAssayTemplate_2.csv 😄
GenomicsAssayTemplate_control.csv 😄
ScRNASeqTemplate_0.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants