Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal dataset access #483

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Portal dataset access #483

merged 5 commits into from
Jul 30, 2024

Conversation

anngvu
Copy link
Collaborator

@anngvu anngvu commented Jul 24, 2024

We don't really use accessType on datasets yet, but this should help with finalizing semantics so that correct code** can be implemented. This update also conveys that datasets don't have to be released (with or without restrictions) to be in the portal listing.

**to derive status from files at the time of dataset new-versioning.

Also see explanation here for the revision: https://sagebionetworks.slack.com/archives/C0AFCTGEQ/p1721857413285619?thread_ts=1721840221.098519&cid=C0AFCTGEQ

These definitions definitely need to go into the Confluence docs somewhere...

Copy link

github-actions bot commented Jul 24, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-30 17:12 UTC

Copy link

Test Suite Report 24.7.1

Template Generation

template result link
ClinicalAssayTemplate 😄 template link
EpigeneticsAssayTemplate 😄 template link
FlowCytometryTemplate 😄 template link
GenomicsAssayTemplate 😄 template link
GenomicsAssayTemplateExtended 😄 template link
HumanCohortTemplate 😄 template link
ImagingAssayTemplate 😄 template link
LightScatteringAssayTemplate 😄 template link
MethylationArrayTemplate 😄 template link
MRIAssayTemplate 😄 template link
PharmacokineticsAssayTemplate 😄 template link
PlateBasedReporterAssayTemplate 😄 template link
ProcessedAlignedReadsTemplate 😄 template link
ProcessedExpressionTemplate 😄 template link
ProcessedVariantCallsTemplate 😄 template link
ProteomicsAssayTemplate 😄 template link
ProtocolTemplate 😄 template link
RNASeqTemplate 😄 template link
ScRNASeqTemplate 😄 template link
UpdateMilestoneReport 😄 template link
WESTemplate 😄 template link
WGSTemplate 😄 template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv 😄 Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv 😄 Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv 😄 Conditional validation for attributes is currently not supported
GenomicsAssayTemplate_control.csv 😄 There should be no issue with this template.
ScRNASeqTemplate_0.csv 😄 Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv 😄 Fail because of missing data in required field libraryStrand

Manifest Submission

manifest pass
GenomicsAssayTemplate_0.csv 😄
GenomicsAssayTemplate_1.csv 😄
GenomicsAssayTemplate_2.csv 😄
GenomicsAssayTemplate_control.csv 😄
ScRNASeqTemplate_0.csv 😄

@anngvu anngvu requested a review from allaway July 24, 2024 21:12
@anngvu anngvu linked an issue Jul 24, 2024 that may be closed by this pull request
@anngvu anngvu changed the title Portal dataset acccess Portal dataset access Jul 25, 2024
@anngvu anngvu requested a review from cconrad8 July 26, 2024 14:38
@anngvu anngvu merged commit f9a5222 into main Jul 30, 2024
@anngvu anngvu deleted the portal-dataset-acccess branch July 30, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Private Access to accessType for PortalDataset
3 participants