Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat - submit tests #442

Merged
merged 21 commits into from
May 7, 2024
Merged

Feat - submit tests #442

merged 21 commits into from
May 7, 2024

Conversation

anngvu
Copy link
Collaborator

@anngvu anngvu commented May 2, 2024

Adds basic feature for submission testing, see #441 and #173. This takes the manifests that passes validation and tries submitting them to a Synapse mock dataset created. This appears to add ~40s to our CI for each mock manifest with 5 rows or so.

@cconrad8 More for awareness since looking at these tests may be more helpful than looking at the official schematic CLI documentation.

Copy link

github-actions bot commented May 2, 2024

Test Suite Report 24.4.1

Template Generation

template result link
AnimalIndividualTemplate 😄 template link
BiospecimenTemplate 😄 template link
ClinicalAssayTemplate 😄 template link
EpigeneticsAssayTemplate 😄 template link
FlowCytometryTemplate 😄 template link
GenomicsAssayTemplateExtended 😄 template link
GenomicsAssayTemplate 😄 template link
HumanCohortTemplate 😄 template link
ImagingAssayTemplate 😄 template link
LightScatteringAssayTemplate 😄 template link
MRIAssayTemplate 😄 template link
MethylationArrayTemplate 😄 template link
PharmacokineticsAssayTemplate 😄 template link
PlateBasedReporterAssayTemplate 😄 template link
ProcessedAlignedReadsTemplate 😄 template link
ProcessedExpressionTemplate 😄 template link
ProcessedVariantCallsTemplate 😄 template link
ProteomicsAssayTemplate 😄 template link
ProtocolTemplate 😄 template link
RNASeqTemplate 😄 template link
ScRNASeqTemplate 😄 template link
UpdateMilestoneReport 😄 template link
WESTemplate 😄 template link
WGSTemplate 😄 template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv Conditional validation for attributes is currently not supported
GenomicsAssayTemplate_control.csv 😄 There should be no issue with this template.
ScRNASeqTemplate_0.csv Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv 😄 Fail because of missing data in required field libraryStrand

Manifest Submission

manifest pass
GenomicsAssayTemplate_control.csv 😄

@anngvu anngvu marked this pull request as ready for review May 6, 2024 17:07
@anngvu anngvu requested review from allaway and cconrad8 May 6, 2024 17:13
Copy link
Contributor

@allaway allaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you. I had one minor readme suggestion.

Co-authored-by: Robert Allaway <allaway@users.noreply.github.com>
@anngvu anngvu merged commit 557ad20 into main May 7, 2024
@anngvu anngvu deleted the feat/submit-tests branch May 7, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants