Update props.yaml

[cconrad8]

to correct the warning that is given when age is blank.

adding '- required ' should ignore the validation rule of number if there is nothing entered

[github-actions]

PR Preview Action v1.4.7
🚀 Deployed preview to https://nf-osi.github.io/nf-metadata-dictionary/pr-preview/pr-427/
on branch gh-pages at 2024-04-17 13:58 UTC

[github-actions]

Test Suite Report

Template Generation

template	result	link
AnimalIndividualTemplate	😄	template link
BiospecimenTemplate	😄	template link
ClinicalAssayTemplate	😄	template link
EpigeneticsAssayTemplate	😄	template link
FlowCytometryTemplate	😄	template link
GenomicsAssayTemplate	😄	template link
GenomicsAssayTemplateExtended	😄	template link
HumanCohortTemplate	😄	template link
ImagingAssayTemplate	😄	template link
LightScatteringAssayTemplate	😄	template link
MethylationArrayTemplate	😄	template link
MRIAssayTemplate	😄	template link
PharmacokineticsAssayTemplate	😄	template link
PlateBasedReporterAssayTemplate	😄	template link
ProcessedAlignedReadsTemplate	😄	template link
ProcessedExpressionTemplate	😄	template link
ProcessedVariantCallsTemplate	😄	template link
ProteomicsAssayTemplate	😄	template link
ProtocolTemplate	😄	template link
RNASeqTemplate	😄	template link
ScRNASeqTemplate	😄	template link
UpdateMilestoneReport	😄	template link
WESTemplate	😄	template link
WGSTemplate	😄	template link

Manifest Validation

manifest	result	expectation
GenomicsAssayTemplate_0.csv	😄	Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv	😄	Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv	😄	Conditional validation for attributes is currently not supported
ScRNASeqTemplate_0.csv	😄	Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv	😄	Fail because of missing data in required field libraryStrand

[cconrad8]

Hmmm @anngvu how do I add validation rules properly?

[cconrad8]

In Gray Foundation it looks like we use something like this

annotations:
   validationRules: regex match ^\d*\.?\d*$|^unknown$

, but here I used pattern: which i found on linkml docs . Thoughts on what the correct syntax is?

[anngvu]

@cconrad8

• For validation rules in general: Use schematic syntax documented in Confluence -- it does make things a lot easier to remember and consistent with all schematic requirements. I'll add a note about that in the README.
• More specifically in this case: I don't think it makes sense that schematic is outputting warnings that "age is not a num" when age is not required and the age field is blank... so it shouldn't be fixed by us changing validation to regex, it should be fixed in schematic.

Edit: should see if anyone has filed this issue already, otherwise we should file.

[anngvu]

Added explanation why not recommended