Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 28NF modelsystemnames #210

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Fix 28NF modelsystemnames #210

merged 3 commits into from
Oct 25, 2022

Conversation

allaway
Copy link
Contributor

@allaway allaway commented Oct 25, 2022

These cell line names were initially added by me, but the names were incorrect. These should actually be 28cNF and i28cNF, not 28NF/i28NF.

@allaway allaway requested a review from anngvu October 25, 2022 20:07
anngvu
anngvu approved these changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@anngvu anngvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I only see the 28cNF and i28cNF in the portal so I guess we're good there.

@allaway allaway merged commit 60de289 into main Oct 25, 2022
@allaway allaway deleted the fix-28NF-modelsystem branch October 25, 2022 23:33
@allaway
Copy link
Contributor Author

allaway commented Oct 25, 2022

Thanks for the quick review!

Yeah....I noticed this error a while ago and had already fixed the annotations. I forgot (until now) to change it in the dictionary too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anngvu anngvu anngvu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allaway @anngvu @nfosi-service