New rules terms #197
Merged
New rules terms #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allaway
reviewed
Aug 12, 2022
| @@ -22,7 +22,7 @@ modelSystemName,"A group of presumed common ancestry with clear-cut physiologica | |||
| nf2Genotype,"Genotype of NF2 gene in the biospecimen from which the data were derived, if known","-/-, +/-, +/+, +/?, -/?, Unknown",,FALSE,,neurofibromatosis,,,,nf2Genotype,Property,Biosample,annotationProperty,,Genotype,, | |||
| nf1Genotype,"Genotype of NF1 gene in the biospecimen from which the data were derived, if known","-/-, +/-, +/+, +/?, -/?, Unknown",,FALSE,,neurofibromatosis,,,,nf1Genotype,Property,Biosample,annotationProperty,,Genotype,, | |||
| specimenPreparationMethod,"Term that represents preservation of the sample before usage in, e.g. sequencing","Fresh collected, Flash frozen, FFPE, Cryopreserved, OCT, RNAlater, formalin-fixed, ethanol, Viably frozen",,FALSE,https://docs.gdc.cancer.gov/Data_Dictionary/viewer/#?view=table-definition-view&id=sample&anchor=preservation_method,ngs,,,,specimenPreparationMethod,Property,Biosample,annotationProperty,,Specimen_State,, | |||
| age,A numeric value representing age of the individual. Use with ageUnit.,,ageUnit,FALSE,Sage Bionetworks,,,,,age,DataProperty,Biosample,annotationProperty,biosampleAnnotation,,, | |||
| age,A numeric value representing age of the individual. Use with ageUnit.,,ageUnit,FALSE,Sage Bionetworks,,,,num,age,DataProperty,Biosample,annotationProperty,biosampleAnnotation,,, | |||
There was a problem hiding this comment.
A couple of minor thoughts on this - some of our contributors (JHU Biobank i think?) don't report young children's exact ages, they do something like <5.
Should we change this validation to regex that will permit the use of < or > (e.g. >89 for Safe Harbor deidentified data)?
allaway
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ageto hopefully make data more consistent #196workflow reportto resourceType #193