add control for CRISPR (or other gene perturbation types) #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfosi-service
approved these changes
Jul 26, 2022
|
@allaway I made some changes. You can confirm that this is better (?) and merge. |
anngvu
approved these changes
Jul 26, 2022
NF.jsonld
Outdated
| @@ -18919,6 +18944,23 @@ | |||
| ], | |||
| "sms:validationRules": [] | |||
| }, | |||
| { | |||
| "@id": "bts:\"\"", | |||
There was a problem hiding this comment.
Need to check this. Where is this random new key coming from?
There was a problem hiding this comment.
Figured out that if there is a space before the "" in valid values, jsonld will contain a key with id "bts:\"\"". Resolved with linting in 05e5def
There was a problem hiding this comment.
Interesting, thanks for catching that!
NF.csv
Outdated
| @@ -724,7 +725,7 @@ compoundName,"Common name for a compound, e.g. “Selumetinib” (https://pubche | |||
| compoundDose,A dose quantity for the treatment compound. To be used with compoundDoseUnit.,,compoundDoseUnit,FALSE,Sage Bionetworks,sageCommunity,,,,compoundDose,Property,Experiment,annotationProperty,experimentProperty,,, | |||
| compoundDoseUnit,A unit associated with the value(s) in compoundDose.,,,FALSE,Sage Bionetworks,sageCommunity,,,,compoundDoseUnit,Property,Experiment,annotationProperty,experimentProperty,,, | |||
| InChIKey,"A unique hash key for a compound, e.g. for “Selumetinib”, the key is CYOHGALHFOKKQC-UHFFFAOYSA-N (https://pubchem.ncbi.nlm.nih.gov/compound/10127622#section=InChI-Key). This is a more reliable identifier than the compound name and should be used if available.",,,FALSE,Sage Bionetworks,sageCommunity,,,,InChIKey,Property,Experiment,annotationProperty,experimentProperty,,, | |||
| genePerturbationType,Specific way in which a single gene was perturbed in a sample,"overexpression, knockdown, knockout, Not Applicable",,FALSE,Sage Bionetworks,cancer,,,,genePerturbationType,Property,Experiment,annotationProperty,,Gene_Perturbation,, | |||
| genePerturbationType,Specific way in which a single gene was perturbed in a sample,"overexpression, knockdown, knockout, control, Not Applicable",,FALSE,Sage Bionetworks,cancer,,,,genePerturbationType,Property,Experiment,annotationProperty,,Gene_Perturbation,, | |||
There was a problem hiding this comment.
Use "non-targeting control"?
There was a problem hiding this comment.
Made change that I suggested in aab5ca9...
There was a problem hiding this comment.
Yup...that is what I should be using. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a gRNA control option for CRISPR experiments to more explicitly describe control samples.