Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing slash from params.igenomes_base #975

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Remove trailing slash from params.igenomes_base #975

merged 1 commit into from
Mar 26, 2021

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 26, 2021

Turns out that Nextflow has been tolerating broken AWS s3 paths for us for years. Let's fix it before anyone notices 🤫

Discussion on Slack in #aws channel: https://nfcore.slack.com/archives/CE7FBAMRP/p1616747167005700

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels changed the title Remove trailing slash from params.igenomes_base Remove trailing slash from params.igenomes_base Mar 26, 2021
FriederikeHanssen
FriederikeHanssen approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 lgtm

@ewels ewels merged commit 11dd693 into nf-core:dev Mar 26, 2021
@ewels ewels deleted the igenomes-paths branch March 26, 2021 15:55
@drpatelh drpatelh mentioned this pull request Jun 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewels @FriederikeHanssen