-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nf-core modules check #878
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #878 +/- ##
==========================================
- Coverage 71.13% 71.08% -0.05%
==========================================
Files 33 33
Lines 3596 3604 +8
==========================================
+ Hits 2558 2562 +4
- Misses 1038 1042 +4
Continue to review full report at Codecov.
|
Do we remove the |
Yup, it's gone from the command line interface. I commented it out and left the stub as we do intend to put that in at a later date (I completely deleted |
As mentioned on Slack we need to change where these modules are installed locally: tools/nf_core/modules/create.py Line 51 in d0b7daf
Need to change this install path to |
Dropped |
Better log warning about missing conda package, plus earlier for ctrl-c exit if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pleasure as always Sir! 💥
https://nfcore.slack.com/archives/CE5LG7WMB/p1615804546224400