-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Slack link in enforcement section to core@ email alias #859
Conversation
Hi @heuermh, It looks like this pull-request has been made against the heuermh/nf-core-tools You do not need to close this PR, you can change the target branch to Thanks again for your contribution! |
This message above is somewhat confusing, I believe it should read nf-core/tools master and dev branches instead of heuermh/nf-core-tools master and dev branches. I am not sure why the branch protection check is failing, after changing the target to |
Yeah, not confusing - plain wrong! When did that creep in? 🤔 The test unfortunately does not re-run after you change the target branch, at least until you push a new commit. I haven't found a way around this yet. |
Thank you, @ewels! |
Merged, thanks 👍🏻 If you fancy it, we also need to update in a few other places 😓
These are the ones that I can think of (aside from those in pipelines that should be updated by the sync / linting). |
Here's the bit that prints that message: tools/.github/workflows/branch.yml Line 26 in 8c68650
So I think it should be + ${{github.event.pull_request.base.repo.full_name}}
- ${{github.event.pull_request.head.repo.full_name}} I'll prep a PR now.. |
See #598
PR checklist
CHANGELOG.md
is updateddocs
is updated