Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor release 1.11 #746

Merged
merged 78 commits into from
Oct 27, 2020
Merged

Minor release 1.11 #746

merged 78 commits into from
Oct 27, 2020

Conversation

ggabernet
Copy link
Member

@ggabernet ggabernet commented Oct 21, 2020 •
edited by ewels
Loading

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

ewels and others added 30 commits July 31, 2020 12:56
@ewels
Sync checkout - fetch everything next time
005f52a
@ewels
Bump v1.11dev
18c3df2
@apeltzer
Merge pull request #720 from ewels/1.11-dev
a06a1dc 
Version bump - 1.11dev
@jpfeuffer
[FIX] Doc links in Readme template
13caf92
@jpfeuffer
Forgot another dot
cc264f6
@ewels
Update nf_core/pipeline-template/{{cookiecutter.name_noslash}}/README.md
8339442
@ewels
Merge pull request #721 from nf-core/fix/readmeTemplateDocLinks
2d707dd 
[FIX] Doc links in Readme template
@ggabernet
fix awstest command
e4efe6a
@ggabernet
update changelog
36fc7b5
@ggabernet
manual trigger for AWS GitHub actions
e91f217
@ggabernet
Merge pull request #722 from ggabernet/dev
844e3dc 
fix awstest command
@jfy133
Fix typo of where -c param is described
70c99d5
@drpatelh
Merge pull request #723 from nf-core/jfy133-patch-1
fc94ad3 
Fix typo of where -c param is described
@Zethson
fixed typo
9045ebe
@drpatelh
Merge pull request #724 from nf-core/fix/typo_branch_yml
d6a43e0 
fixed typo
remove outdated TODO in template
40cf1cc
fix url in readme template
36cc2eb
resolve merge conflict
5bfdeeb
update changelog
0c71c1f
fix one more dead docs link
e19d6e4
@apeltzer
Merge pull request #728 from mashehu/remove-todo
7f82b8a 
remove outdated TODO in template
@drpatelh
move NOT mov
06e1b5a
@drpatelh
Merge pull request #729 from drpatelh/schema_bug
b7cba8a 
move NOT mov
@maxulysse
remove docs from README Template and simplify Documentation section
89b95f0
@maxulysse
simpler links
e067ed5
@BatoolMM
corrected the blue part in a part of the nf-core ascii art #736
596dd40
@BatoolMM
Code formatting with Black
3a38656
@BatoolMM
Black formatting
0bfdc4d
@ewels
Merge pull request #740 from BatoolMM/master
9cf91be 
Wrong blue in a part of the nf-core ascii art #736
@maxulysse
Update CONTRIBUTING.md
82a61de 
`docs` does not exist anymore. I do think either `usage` would be a good idea.
cf https://github.com/nf-core/eager/pull/573/files#r501670722
ggabernet and others added 13 commits October 23, 2020 09:50
@ggabernet
update AWS wf lint test
9786cd8
@ggabernet
fix lint awstest
65a6b93
@ggabernet
schema lint title description
adcfdf8
@ggabernet
update schema test working example
a718f7e
@ggabernet
black format lint.py
5ea5d2b
@ggabernet
update tests max_pass
69388b7
@ewels
Merge pull request #754 from nf-core/feature/podman_docs
b666ae2 
Added Podman documentation
@ewels @maxulysse
Update nf_core/pipeline-template/{{cookiecutter.name_noslash}}/docs/o…
5e95a3d 
…utput.md

Co-authored-by: Maxime Garcia <maxime.garcia@scilifelab.se>
@ewels @maxulysse
Update nf_core/pipeline-template/{{cookiecutter.name_noslash}}/docs/u…
e11a77d 
…sage.md

Co-authored-by: Maxime Garcia <maxime.garcia@scilifelab.se>
@ewels
Merge pull request #752 from ewels/markdown-docs-notice
e73df47 
Added notice to top of docs markdown files to use the website.
@ewels
Merge pull request #751 from ewels/manual-sync-triger
4903af7 
GitHub Actions sync - add manual 'workflow' trigger
@ewels
Update nf_core/lint.py
f358e07
@ewels
Merge pull request #755 from ggabernet/dev
387c844 
AWS actions linting update
@ggabernet ggabernet marked this pull request as ready for review October 26, 2020 19:30
@ggabernet ggabernet requested review from ewels and a team October 26, 2020 19:30
@ggabernet
Copy link
Member Author

maybe we wait till tomorrow for the release but just marked it as ready for review in case someone wants to check it already today ;)

@ewels
Copy link
Member

ewels commented Oct 26, 2020

I'm happy with pushing the release tomorrow morning 🚀

ewels
ewels approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good I think!

apeltzer
apeltzer approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great - thank you 🙇

@ewels ewels mentioned this pull request Oct 27, 2020
Merged
ggabernet
ggabernet commented Oct 27, 2020
View reviewed changes
ewels and others added 3 commits October 27, 2020 10:08
@ewels
v1.11 not v1.11.0
2450baa
@ewels @ggabernet
Update nf_core/lint.py
e98d8e6 
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
@ewels
Merge pull request #756 from ewels/v1.11-release-name
af129da 
Added release name and date to v1.11 changelog
@ggabernet
Copy link
Member Author

What about the nf-core base docker container for v1.11 then? I am not sure where this is created and wanted to make sure it says 1.11 and not 1.11.0

@ewels ewels merged commit 9b3eec9 into master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

@apeltzer apeltzer apeltzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ggabernet @ewels @apeltzer @jpfeuffer @jfy133 @drpatelh @Zethson @maxulysse @BatoolMM