Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new command: nf-core logo-create to output an nf-core logo for a pipeline (instead of going through the website) #2662

Merged
merged 49 commits into from
Jan 18, 2024
Merged

new command: nf-core logo-create to output an nf-core logo for a pipeline (instead of going through the website) #2662

merged 49 commits into from
Jan 18, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Jan 16, 2024

No description provided.

@mashehu mashehu requested review from ewels and mirpedrol January 16, 2024 14:46
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2024 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c453edf) 73.05% compared to head (1fe7f05) 73.27%.
Report is 3 commits behind head on dev.

Files Patch % Lines
nf_core/__main__.py 95.83% 3 Missing ⚠️
nf_core/create_logo.py 98.11% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ewels
ewels reviewed Jan 17, 2024
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! Haven't tested it yet but first pass on the code looks good.

nf_core/pipeline-template/.github/workflows/download_pipeline.yml Outdated Show resolved Hide resolved
nf_core/create.py Outdated Show resolved Hide resolved
nf_core/__main__.py Outdated Show resolved Hide resolved
nf_core/__main__.py Outdated Show resolved Hide resolved
nf_core/__main__.py Outdated Show resolved Hide resolved
nf_core/__main__.py Outdated Show resolved Hide resolved
mirpedrol
mirpedrol reviewed Jan 17, 2024
View reviewed changes
nf_core/__main__.py Outdated Show resolved Hide resolved
nf_core/__main__.py Outdated Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
mirpedrol
mirpedrol approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

nf_core/create.py Outdated Show resolved Hide resolved
ewels
ewels approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor suggested changes / fixes, otherwise good to go 👍🏻

nf_core/__main__.py Show resolved Hide resolved
nf_core/__main__.py Outdated Show resolved Hide resolved
nf_core/create_logo.py Outdated Show resolved Hide resolved
nf_core/__main__.py Outdated Show resolved Hide resolved
mashehu and others added 3 commits January 18, 2024 15:25
mashehu
mashehu commented Jan 18, 2024
View reviewed changes
tests/test_cli.py Outdated Show resolved Hide resolved
@mashehu mashehu merged commit 7d9e37e into nf-core:dev Jan 18, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mashehu @ewels @mirpedrol @nf-core-bot