Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort the installed_by list in modules.json #2570

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Sort the installed_by list in modules.json #2570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43af5b1
Sort the list in
mirpedrol Dec 11, 2023
1fd25de
update changelog
mirpedrol Dec 11, 2023
954daee
Sort the installed_by list in modules.json, now right
mirpedrol Dec 11, 2023
ebf162f
Merge branch 'dev' into sort-modules-json-list
mirpedrol Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
- Add mypy to pre-commit config for the tools repo ([#2545](https://github.com/nf-core/tools/pull/2545))
- Use Path objects for ComponentCreate and update the structure of components templates ([#2551](https://github.com/nf-core/tools/pull/2551)).
- GitPod base image: swap tool installation back to `conda` from `mamba` ([#2566](https://github.com/nf-core/tools/pull/2566)).
- Sort the `installed_by` list in `modules.json` ([#2570](https://github.com/nf-core/tools/pull/2570)).
- Unset env variable JAVA_TOOL_OPTIONS in gitpod ([#2569](https://github.com/nf-core/tools/pull/2569))

# [v2.10 - Nickel Ostrich](https://github.com/nf-core/tools/releases/tag/2.10) + [2023-09-25]
Expand Down
2 changes: 1 addition & 1 deletion nf_core/modules/modules_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ def update(
repo_component_entry[component_name]["installed_by"] = [installed_by]
finally:
new_installed_by = repo_component_entry[component_name]["installed_by"] + list(installed_by_log)
repo_component_entry[component_name]["installed_by"] = [*set(new_installed_by)]
repo_component_entry[component_name]["installed_by"] = sorted([*set(new_installed_by)])

# Sort the 'modules.json' repo entries
self.modules_json["repos"] = nf_core.utils.sort_dictionary(self.modules_json["repos"])
Expand Down
Loading