Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/python typing/components command.py #2223

Merged
Merged
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
8295f77
my repo test
NovakApis Mar 28, 2023
b803580
Merge branch 'dev' into feature/python-typing/components_command.py
NovakApis Mar 28, 2023
68513c0
black + isort
NovakApis Mar 28, 2023
203a04b
first test
NovakApis Mar 28, 2023
2b044f8
python-typing/components_command.py
NovakApis Mar 28, 2023
31b474d
add mypy ci check
fabianegli Mar 28, 2023
47b9779
made some variable types depend on function return value
NovakApis Mar 29, 2023
ef93b96
updated __init__ keyword arguments
NovakApis Mar 29, 2023
5262237
Merge branch 'dev' into feature/python-typing/components_command.py
fabianegli Mar 29, 2023
4afe175
make mypy ignore missing imports
fabianegli Mar 29, 2023
a679153
mypy configuration edit
NovakApis Mar 29, 2023
a1119f6
use mypy without pre-built action
fabianegli Apr 3, 2023
ba848af
fix typo in mypy target directory
fabianegli Apr 3, 2023
2003c5e
install missing type annotations for mypy
fabianegli Apr 3, 2023
a503c16
install types non-interactive and with a target
fabianegli Apr 3, 2023
3d978de
install mypy check requirements explicitly
fabianegli Apr 3, 2023
e3348df
install tools dependencies for mypy checks
fabianegli Apr 3, 2023
325f043
allow redefinition in mypy checks
fabianegli Apr 3, 2023
0b25bfa
ignore redefinitions in mypy checks
fabianegli Apr 3, 2023
3c75ee8
use tool prefix for mypy section
fabianegli Apr 3, 2023
7aa26f5
make disable error code a string
fabianegli Apr 3, 2023
d7b2c04
Merge branch 'dev' into feature/python-typing/components_command.py
kedhammar Oct 16, 2023
e91f64e
Update nf_core/components/components_command.py
kedhammar Oct 16, 2023
3b75418
Update nf_core/components/components_command.py
kedhammar Oct 16, 2023
594f62f
Update nf_core/components/components_command.py
kedhammar Oct 16, 2023
64cef2f
Update nf_core/components/components_command.py
kedhammar Oct 16, 2023
9291733
Update nf_core/components/components_command.py
kedhammar Oct 16, 2023
c394848
Update nf_core/components/components_command.py
kedhammar Oct 16, 2023
f31c933
Update nf_core/components/components_command.py
kedhammar Oct 16, 2023
c5c8cda
Try adding mypy to pre-commit config
kedhammar Oct 16, 2023
681eb5e
Fix invalid pre-commit config
kedhammar Oct 16, 2023
fc1be87
Revert pre-commit change for now
kedhammar Oct 16, 2023
315438d
Try changing CI to only run mypy on changed files
kedhammar Oct 16, 2023
dcaa124
Differentiate dir arg (optional) from dir path
kedhammar Oct 16, 2023
9db5fd5
Declare type within func
kedhammar Oct 16, 2023
d9972b6
Try installing MyPy stubs
kedhammar Oct 17, 2023
6d8156f
Specify missing stubs
kedhammar Oct 17, 2023
62cb1b9
try passing mypy
kedhammar Oct 17, 2023
95eb4b3
prettier
kedhammar Oct 17, 2023
bf60f5f
bump python version
kedhammar Oct 17, 2023
dba49b3
bugfix
kedhammar Oct 17, 2023
73e2e72
try reverting variable differentiation and instead adapt initial typi…
kedhammar Oct 17, 2023
2c234bd
Don't combine typing square bracket syntax with non-subscriptable abc…
kedhammar Oct 17, 2023
78b078c
Try further simplifying typing to prevent pytest suite from trying to…
kedhammar Oct 17, 2023
fbeafa4
extend last commit to this file
kedhammar Oct 17, 2023
b91c88e
Supplement typing and remove superfluous code
kedhammar Oct 17, 2023
6b4f9ff
isort
kedhammar Oct 17, 2023
d5c11b5
supplement typing, 2 errors left
kedhammar Oct 17, 2023
3d81425
1 error left
kedhammar Oct 17, 2023
5c88dbf
Try fixing typing error by clarifying list-of-dicts parsing
kedhammar Oct 17, 2023
a7b26b3
Fix mypy complaints across entire repo
kedhammar Oct 17, 2023
ce13018
add stubs
kedhammar Oct 17, 2023
12a8adf
isort
kedhammar Oct 17, 2023
c97ef6e
try reading custom config in GHA
kedhammar Oct 17, 2023
ee920c8
Revert last 4 commits
kedhammar Oct 17, 2023
989f1b7
Update .github/workflows/lint-code.yml
kedhammar Oct 17, 2023
56b6a08
Update .github/workflows/lint-code.yml
kedhammar Oct 17, 2023
b518c1c
Update nf_core/components/components_command.py
kedhammar Oct 17, 2023
4e71fb8
Update nf_core/components/components_utils.py
kedhammar Oct 17, 2023
7edf84f
Update nf_core/components/components_utils.py
kedhammar Oct 17, 2023
ddf4fda
import missing typing obj
kedhammar Oct 17, 2023
e88d721
black
kedhammar Oct 17, 2023
9171fa0
revert minor tweak to prevent breaking
kedhammar Oct 17, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use tool prefix for mypy section
  • Loading branch information
fabianegli authored Apr 3, 2023
commit 3c75ee859239ea7044f2dd9f0e21cfe60d23d1f4
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ profile = "black"
known_first_party = ["nf_core"]
multi_line_output = 3

[mypy]
[tool.mypy]
ignore_missing_imports = true
follow_imports = "skip"
disable_error_code = no-redef