-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for nf-core subworkflows create-test-yml
#2219
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2219 +/- ##
==========================================
+ Coverage 71.99% 72.96% +0.96%
==========================================
Files 78 78
Lines 8385 8385
==========================================
+ Hits 6037 6118 +81
+ Misses 2348 2267 -81
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@nf-core-bot fix linting |
0039e2e
to
49c3bd9
Compare
49c3bd9
to
a661087
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for doing this!
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
[skip ci]
Thanks for the reviews! |
This PR adds unit-tests for
nf-core subworkflows create-test-yml
.The code in
nf_core/subworkflows/test_yml_builder.py
is very similar to its module equivalent, so the new tests are more or less a copy of the module tests. Maybe it would be worth refactoringSubworkflowTestYmlBuilder
andModuleTestYmlBuilder
to avoid code duplication?Closes #1895
PR checklist
CHANGELOG.md
is updated