Fix nf-core subworkflows test #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 9, 2023
Codecov Report
@@ Coverage Diff @@
## dev #2181 +/- ##
==========================================
+ Coverage 71.51% 71.53% +0.01%
==========================================
Files 77 77
Lines 8338 8350 +12
==========================================
+ Hits 5963 5973 +10
- Misses 2375 2377 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mashehu
approved these changes
Feb 9, 2023
| except LookupError as e: | ||
| # If the module to be updated is not available, check if there has been a name change | ||
| if "not found in list of available" in str(e): | ||
| # Skip update, we check for name changes with manage_changes_in_linked_components in line #261 |
There was a problem hiding this comment.
Suggested change
| # Skip update, we check for name changes with manage_changes_in_linked_components in line #261 | |
| # Skip update, we check for name changes with manage_changes_in_linked_components |
I am afraid that line number reference will be outdated soon, so just referencing the method should be good enough
There was a problem hiding this comment.
I will change it in #2177 and merge that one as you reviewed here already 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nf-core subworkflows test by adding the prefix "subworkflows/" to the pytest tag.
Merge after the GHA bug fix in #2177
Close #2180
PR checklist
CHANGELOG.mdis updateddocsis updated