Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle json.load() exceptions #2134

Merged
merged 11 commits into from
Dec 17, 2022
Prev Previous commit
Next Next commit
fix test
  • Loading branch information
mirpedrol committed Dec 15, 2022
commit 3b2f53d1f6477ddef588ca6bdcc287253b7df626
6 changes: 6 additions & 0 deletions tests/modules/update.py
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,12 @@ def test_update_only_show_differences(self, mock_prompt):
modules_json = ModulesJson(self.pipeline_dir)
update_obj = ModuleUpdate(self.pipeline_dir, update_all=True, show_diff=True)

# Update modules to a fixed old SHA
update_old = ModuleUpdate(
self.pipeline_dir, update_all=True, show_diff=False, sha="5e34754d42cd2d5d248ca8673c0a53cdf5624905"
)
update_old.update()

tmpdir = tempfile.mkdtemp()
shutil.rmtree(tmpdir)
shutil.copytree(Path(self.pipeline_dir, "modules", NF_CORE_MODULES_NAME), tmpdir)
Expand Down