fix new syntax form set_output in sync.yml #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mashehu
approved these changes
Dec 8, 2022
Codecov Report
@@ Coverage Diff @@
## dev #2110 +/- ##
=======================================
Coverage 67.97% 67.97%
=======================================
Files 43 43
Lines 5633 5633
=======================================
Hits 3829 3829
Misses 1804 1804 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mashehu
requested changes
Dec 8, 2022
.github/workflows/sync.yml
Outdated
| @@ -27,7 +27,7 @@ jobs: | |||
| else | |||
| curl -O https://nf-co.re/pipeline_names.json | |||
| fi | |||
| echo "name=matrix::$(cat pipeline_names.json)" >> $GITHUB_OUTPUT | |||
| echo "matrix==$(cat pipeline_names.json)" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
do we need a comparison here
There was a problem hiding this comment.
whoops no! It was a typo
I am basing the change on these docs, if you want to double check
mashehu
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
CHANGELOG.mdis updateddocsis updated