-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove citation.cff file from pipeline template #2059
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2059 +/- ##
==========================================
+ Coverage 67.58% 67.63% +0.04%
==========================================
Files 43 43
Lines 5572 5555 -17
==========================================
- Hits 3766 3757 -9
+ Misses 1806 1798 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny minor change :)
I otherwise approve the change because 1) there is still CITATION.cff at the root of this repo (nf-core/tools) and 2) the nf-core paper is still listed in CITATIONS.nd in the pipeline template
Bit of a shame, but ok. Kind of annoying behaviour from Zenodo! No way to disable this on the Zenodo side? |
Not sure, but @apeltzer has the keys to the Zenodo configuration for nf-core pipelines |
Not really anything configurable. Once I found time to work on using the API we can likely get around it. |
Co-authored-by: Matthieu Muffato <cortexspam-github@yahoo.fr>
We had issues on Zenodo releases that would mention the nf-core publication instead of the pipeline name and release because of the
citation.cff
file.PR checklist
CHANGELOG.md
is updateddocs
is updated