Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial CHM13 support to template #1990

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Add initial CHM13 support to template #1990

merged 2 commits into from
Mar 7, 2023

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Nov 1, 2022

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Closes #1988

@edmundmiller edmundmiller self-assigned this Nov 1, 2022
@edmundmiller edmundmiller changed the base branch from master to dev November 1, 2022 15:06
@nf-core nf-core deleted a comment from github-actions bot Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #1990 (9dcb778) into dev (6bf8f30) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1990   +/-   ##
=======================================
  Coverage   62.01%   62.01%           
=======================================
  Files          42       42           
  Lines        4862     4862           
=======================================
  Hits         3015     3015           
  Misses       1847     1847           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
sorry for the late review, there will be some changelog conflicts but should be easy to fix

@edmundmiller edmundmiller merged commit 4a29080 into dev Mar 7, 2023
@edmundmiller edmundmiller deleted the CHM13 branch March 7, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CHM13 igenomes to template
2 participants