Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless shebang lines #1973

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

fabianegli
Copy link
Contributor

@fabianegli fabianegli commented Oct 26, 2022

The shebang lines are useful for python files which are run as scripts in the console. Many of the files in a package are not. This PR removes the shebang line from the files that do not serve as scripts.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #1973 (00314a7) into dev (6bf8f30) will decrease coverage by 0.97%.
The diff coverage is n/a.

❗ Current head 00314a7 differs from pull request most recent head 5e9fcae. Consider uploading reports for the commit 5e9fcae to get more accurate results

@@            Coverage Diff             @@
##              dev    #1973      +/-   ##
==========================================
- Coverage   62.01%   61.03%   -0.98%     
==========================================
  Files          42       37       -5     
  Lines        4862     4666     -196     
==========================================
- Hits         3015     2848     -167     
+ Misses       1847     1818      -29     
Impacted Files Coverage Δ
nf_core/bump_version.py 89.47% <ø> (-0.19%) ⬇️
nf_core/download.py 52.72% <ø> (-0.12%) ⬇️
nf_core/launch.py 63.58% <ø> (-0.10%) ⬇️
nf_core/licences.py 22.85% <ø> (-1.09%) ⬇️
nf_core/lint/modules_structure.py 88.88% <ø> (ø)
nf_core/lint/multiqc_config.py 66.66% <ø> (ø)
nf_core/lint/pipeline_name_conventions.py 81.81% <ø> (ø)
nf_core/lint/pipeline_todos.py 94.11% <ø> (ø)
nf_core/lint/readme.py 75.75% <ø> (ø)
nf_core/lint/schema_description.py 67.85% <ø> (ø)
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fabianegli fabianegli force-pushed the remove-useless-shebang branch from 00314a7 to 5e9fcae Compare October 30, 2022 16:18
@fabianegli fabianegli merged commit 0c904f4 into nf-core:dev Nov 15, 2022
@fabianegli fabianegli deleted the remove-useless-shebang branch November 15, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants