Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): Update ci jobs to use nodejs16 #1944

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Oct 12, 2022

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

nf-core/modules#2238

@edmundmiller edmundmiller self-assigned this Oct 12, 2022
@edmundmiller edmundmiller changed the base branch from master to dev October 12, 2022 14:42
@nf-core nf-core deleted a comment from github-actions bot Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #1944 (6bd773f) into dev (ee6b104) will decrease coverage by 7.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1944      +/-   ##
==========================================
- Coverage   69.23%   61.38%   -7.86%     
==========================================
  Files          59       37      -22     
  Lines        7148     4677    -2471     
==========================================
- Hits         4949     2871    -2078     
+ Misses       2199     1806     -393     
Impacted Files Coverage Δ
nf_core/modules/modules_command.py 67.76% <0.00%> (-16.02%) ⬇️
nf_core/modules/modules_repo.py 75.81% <0.00%> (-8.40%) ⬇️
nf_core/modules/modules_differ.py 84.42% <0.00%> (-2.02%) ⬇️
nf_core/modules/lint/main_nf.py 64.61% <0.00%> (-1.16%) ⬇️
nf_core/modules/lint/__init__.py 82.53% <0.00%> (-0.53%) ⬇️
nf_core/modules/info.py 16.54% <0.00%> (-0.50%) ⬇️
nf_core/schema.py 76.07% <0.00%> (-0.21%) ⬇️
nf_core/__main__.py 53.39% <0.00%> (-0.12%) ⬇️
nf_core/modules/nfcore_module.py 100.00% <0.00%> (ø)
nf_core/lint/nextflow_config.py
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@edmundmiller edmundmiller merged commit 409a6db into dev Oct 12, 2022
@edmundmiller edmundmiller deleted the update-actions branch October 12, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants