-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker_m1 profile #1942
Add docker_m1 profile #1942
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1942 +/- ##
==========================================
- Coverage 67.41% 67.36% -0.06%
==========================================
Files 42 42
Lines 5463 5463
==========================================
- Hits 3683 3680 -3
- Misses 1780 1783 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@nf-core-bot fix linting |
I think this needs to come with some kind of documented warning, either at runtime, in the docs, or (preferably imo) both. Whilst the platform option does allow you to get a lot of the functionality and compatibility it can also lead to incredibly slow processes where the emulation doesn't cut it. It's also possible that you lose a lot of performance running under emulation when native EDIT: In fact I don't think the platform variable is necessary to pull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me!
Maybe to address @awgymer's comment we could add a warning in the documentation, so users only use this profile in case of problems with the regular docker one.
I also have an M1 chip and this was a solution I found, but I don't have enough knowledge to know if this can become a problem for someone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are more future-proof if we call it docker_arm
, since there are already M2 out and in theory other ARM chips would work with this as well (when someone wants to run nextflow on their phones for example 😜).
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
a bit late to the party, but why not using the current docker profile and adding an arm profile with just the docker option so we can do |
Good idea :) I made the PR here #2034 |
docker_m1
profile to pipeline as suggested by @snafees to be able to run pipelines with the docker profile on the Apple M1 chipsPR checklist
CHANGELOG.md
is updateddocs
is updated