Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code maintenance #1747

Merged
merged 14 commits into from
Aug 16, 2022
Merged

Code maintenance #1747

merged 14 commits into from
Aug 16, 2022

Conversation

fabianegli
Copy link
Contributor

A couple of minor code changes - mostly maintenance but also fixes one function call that had too many arguments.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@fabianegli fabianegli changed the title Maint lint modules json Minor code maintenance Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1747 (cd0e5a4) into dev (ccad6e6) will decrease coverage by 0.03%.
The diff coverage is 70.52%.

@@            Coverage Diff             @@
##              dev    #1747      +/-   ##
==========================================
- Coverage   68.45%   68.41%   -0.04%     
==========================================
  Files          59       59              
  Lines        7136     7121      -15     
==========================================
- Hits         4885     4872      -13     
+ Misses       2251     2249       -2     
Impacted Files Coverage Δ
nf_core/licences.py 23.94% <0.00%> (ø)
nf_core/lint/__init__.py 73.85% <0.00%> (ø)
nf_core/modules/lint/module_patch.py 10.66% <0.00%> (ø)
nf_core/modules/lint/module_tests.py 70.73% <0.00%> (ø)
nf_core/modules/remove.py 82.14% <ø> (-1.73%) ⬇️
nf_core/refgenie.py 75.67% <0.00%> (ø)
nf_core/__main__.py 52.66% <33.33%> (ø)
nf_core/modules/modules_repo.py 82.38% <50.00%> (ø)
nf_core/modules/modules_json.py 72.05% <60.00%> (ø)
nf_core/utils.py 81.12% <64.28%> (+0.15%) ⬆️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fabianegli fabianegli changed the title Minor code maintenance Code maintenance Aug 12, 2022
@fabianegli fabianegli merged commit 43e125a into nf-core:dev Aug 16, 2022
@fabianegli fabianegli deleted the maint-lint-modules-json branch August 16, 2022 11:00
@fabianegli
Copy link
Contributor Author

@mirpedrol Thank you for the review and approving the PR (and the ones just before). 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants