Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert console snippets to bash snippets in the template #1729

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Aug 3, 2022

console snippets are in general only nice to display terminal outputs, not anything related to scripts or commands.

PR checklist

  • This comment contains a description of changes (with reason)

`console` snippets are in general only nice to display terminal outputs, not anything related to scripts or commands.
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #1729 (447b2d5) into dev (a9d0665) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1729      +/-   ##
==========================================
- Coverage   68.29%   68.17%   -0.12%     
==========================================
  Files          59       59              
  Lines        7063     7071       +8     
==========================================
- Hits         4824     4821       -3     
- Misses       2239     2250      +11     
Impacted Files Coverage Δ
nf_core/modules/modules_command.py 84.00% <0.00%> (-3.81%) ⬇️
nf_core/modules/module_test.py 53.33% <0.00%> (-1.47%) ⬇️
nf_core/modules/test_yml_builder.py 47.24% <0.00%> (-1.38%) ⬇️
nf_core/modules/list.py 71.23% <0.00%> (-0.39%) ⬇️
nf_core/modules/install.py 72.36% <0.00%> (-0.36%) ⬇️
nf_core/utils.py 80.89% <0.00%> (-0.20%) ⬇️
nf_core/modules/update.py 78.36% <0.00%> (-0.09%) ⬇️
nf_core/modules/patch.py 81.48% <0.00%> (ø)
nf_core/modules/lint/__init__.py 82.98% <0.00%> (+0.01%) ⬆️
nf_core/modules/info.py 17.16% <0.00%> (+0.24%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ErikDanielsson ErikDanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you should update the changelog (:

@mashehu
Copy link
Contributor Author

mashehu commented Aug 3, 2022

Done! 🙂

Copy link
Contributor

@ErikDanielsson ErikDanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@mashehu mashehu merged commit 3febadb into nf-core:dev Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants