Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retrieve last common build of a module for Docker and Singularity #1702

Merged
merged 6 commits into from
Jul 28, 2022
Merged

retrieve last common build of a module for Docker and Singularity #1702

merged 6 commits into from
Jul 28, 2022

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Jul 27, 2022 •
edited
Loading

Closes #1656

When obtaining Docker and Singularity containers from a bioconda package and version, get the latest common build for both containers.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jul 27, 2022 •
edited
Loading

Codecov Report

Merging #1702 (30f7ea0) into dev (aff3286) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1702      +/-   ##
==========================================
+ Coverage   68.23%   68.28%   +0.04%     
==========================================
  Files          57       57              
  Lines        6746     6756      +10     
==========================================
+ Hits         4603     4613      +10     
  Misses       2143     2143
Impacted Files Coverage Δ
nf_core/utils.py 80.86% <100.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aff3286...30f7ea0. Read the comment docs.

@mirpedrol mirpedrol changed the title retrieve las common build of a module for Docker and Singularity retrieve last common build of a module for Docker and Singularity Jul 27, 2022
@mirpedrol mirpedrol marked this pull request as ready for review July 27, 2022 08:02
@mirpedrol mirpedrol requested a review from ErikDanielsson July 27, 2022 11:06
ErikDanielsson
ErikDanielsson reviewed Jul 27, 2022
View reviewed changes
Copy link
Contributor

@ErikDanielsson ErikDanielsson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one suggestion

nf_core/utils.py Outdated Show resolved Hide resolved
mirpedrol and others added 2 commits July 28, 2022 09:13
@mirpedrol @ErikDanielsson
Apply suggestion from code review
8fd6a62 
Co-authored-by: Erik Danielsson <53212377+ErikDanielsson@users.noreply.github.com>
@mirpedrol
fix typo
445402a
ErikDanielsson
ErikDanielsson approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@ErikDanielsson ErikDanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just add the suggestion (I created a bug with my earlier suggestion ;))

nf_core/utils.py Outdated Show resolved Hide resolved
@mirpedrol @ErikDanielsson
Update nf_core/utils.py
30f7ea0 
Co-authored-by: Erik Danielsson <53212377+ErikDanielsson@users.noreply.github.com>
@mirpedrol mirpedrol merged commit 34e7bf7 into nf-core:dev Jul 28, 2022
@mirpedrol mirpedrol deleted the create-versions branch July 28, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikDanielsson ErikDanielsson ErikDanielsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirpedrol @ErikDanielsson