Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in ModulesJson #1690

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Conversation

ErikDanielsson
Copy link
Contributor

Fixed bug in ModulesJson.check_up_to_date causing local modules to not be filtered out when looking for the remote of untracked files.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #1690 (70f5175) into dev (d363205) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1690   +/-   ##
=======================================
  Coverage   67.88%   67.88%           
=======================================
  Files          56       56           
  Lines        6677     6677           
=======================================
  Hits         4533     4533           
  Misses       2144     2144           
Impacted Files Coverage Δ
nf_core/modules/modules_json.py 63.26% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d363205...70f5175. Read the comment docs.

@ErikDanielsson ErikDanielsson requested a review from mirpedrol July 21, 2022 13:58
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ErikDanielsson
Copy link
Contributor Author

Thanks!

@ErikDanielsson ErikDanielsson merged commit 1d427a2 into nf-core:dev Jul 21, 2022
@ErikDanielsson ErikDanielsson deleted the fix-bug-localmod branch July 26, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants