-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch CI to nf-core/setup-nextflow action #1650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Can maybe also remove the CAPSULE_LOG: none
env vars too (see https://github.com/MillironX/setup-nextflow/issues/1 )
Also update if we're moving to nf-core, as discussed in Slack 👍🏻
Otherwise LGTM! 💥
Converting to draft until two things are fixed:
|
Tests are now passing, so this is actually ready for review. |
Codecov Report
@@ Coverage Diff @@
## dev #1650 +/- ##
=======================================
Coverage 64.84% 64.84%
=======================================
Files 54 54
Lines 6270 6270
=======================================
Hits 4066 4066
Misses 2204 2204
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few lurking CAPSULE_LOG
env vars left I think? Otherwise the code LGTM 👍🏻
Switches the workflows in this repo and the template to point to use setup-nextflow, rather than try to manually install Nextflow in a
run:
block. This allows for simplifying the execution matrix, and removes the need to keep track of whether a stable or edge release is actually the most recent.PR checklist
CHANGELOG.md
is updateddocs
is updated