Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1595 #1598

Merged
merged 3 commits into from
May 25, 2022
Merged

Fix 1595 #1598

merged 3 commits into from
May 25, 2022

Conversation

fabianegli
Copy link
Contributor

@fabianegli fabianegli commented May 19, 2022 •
edited
Loading

Fix the regex which extracts the version string from "https://containers" and "https://depot" URLs.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Closes #1595

@codecov
Copy link

codecov bot commented May 19, 2022 •
edited
Loading

Codecov Report

Merging #1598 (5b76863) into dev (67b2b48) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #1598   +/-   ##
=======================================
  Coverage   64.65%   64.65%           
=======================================
  Files          54       54           
  Lines        6232     6232           
=======================================
  Hits         4029     4029           
  Misses       2203     2203
Impacted Files Coverage Δ
nf_core/modules/lint/main_nf.py 76.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b2b48...5b76863. Read the comment docs.

@fabianegli fabianegli mentioned this pull request May 19, 2022
Merged
4 tasks
mirpedrol
mirpedrol approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

nf_core/modules/lint/main_nf.py Outdated Show resolved Hide resolved
@fabianegli
Copy link
Contributor Author

Now, the regex extraction is back on one line.

@fabianegli fabianegli requested a review from mirpedrol May 25, 2022 10:42
mirpedrol
mirpedrol approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I believe it can be merged :)

@fabianegli fabianegli merged commit 744068d into nf-core:dev May 25, 2022
@fabianegli fabianegli deleted the fix-1595 branch July 21, 2022 16:21
@ErikDanielsson ErikDanielsson mentioned this pull request Jul 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianegli @mirpedrol