Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove color label in Nextflow image from readme linting #1590

Merged
merged 3 commits into from
May 17, 2022

Conversation

mirpedrol
Copy link
Member

Close #1589

Remove color label in Nextflow image from readme linting to fix "readme: README did not have a Nextflow minimum version badge." warning.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #1590 (8aaccfd) into dev (c560450) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1590      +/-   ##
==========================================
+ Coverage   64.58%   64.63%   +0.04%     
==========================================
  Files          54       54              
  Lines        6249     6249              
==========================================
+ Hits         4036     4039       +3     
+ Misses       2213     2210       -3     
Impacted Files Coverage Δ
nf_core/lint/readme.py 79.31% <100.00%> (+10.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c560450...8aaccfd. Read the comment docs.

@mirpedrol mirpedrol marked this pull request as ready for review May 17, 2022 13:27
@praveenraj2018 praveenraj2018 linked an issue May 17, 2022 that may be closed by this pull request
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mirpedrol !

@mirpedrol mirpedrol merged commit 34d472f into nf-core:dev May 17, 2022
@mirpedrol mirpedrol deleted the lint branch May 17, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint warning on Nextflow minimum version badge
2 participants