Make temporary folders temporary #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
fabianegli
added a commit
to fabianegli/tools
that referenced
this pull request
May 12, 2022
fabianegli
added a commit
to fabianegli/tools
that referenced
this pull request
May 12, 2022
This reverts commit 4a0f2f2.
fabianegli
added a commit
to fabianegli/tools
that referenced
this pull request
May 12, 2022
This reverts commit 4a0f2f2.
mirpedrol
approved these changes
May 13, 2022
|
I also sneaked in a Deprecation warning for |
|
Missing changelog, for next time :) (I'll add something now) |
|
Sorry for that, and thank you for taking care of the changelog. |
|
No worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for list left a remnant folder in
/tmp/namednxfwhich I believe to be an undesired behaviour.I also took the opportunity to use pathlib.Path, isort and simplify some of the code in
list.py(and make it marginally faster).PR checklist
CHANGELOG.mdis updateddocsis updatedCloses #1565