Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove md5sum for versions.yml file #1511

Merged
merged 10 commits into from
Apr 15, 2022
Merged

Remove md5sum for versions.yml file #1511

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9cdf4bc
remove md5sum for versions.yml file
Apr 12, 2022
10fe141
modify changelog
Apr 12, 2022
cd78ef9
Update CHANGELOG.md
mirpedrol Apr 13, 2022
708c807
Use continue in if statement
mirpedrol Apr 13, 2022
6d4b103
Update nf_core/modules/test_yml_builder.py
ewels Apr 13, 2022
a8baf99
apply refactoring from review suggestions
Apr 13, 2022
7362163
apply refactoring from review suggestions
Apr 13, 2022
afce274
Merge branch 'dev' into test_yml
mirpedrol Apr 13, 2022
66d1e98
fix linting
Apr 13, 2022
7772e5a
restore deleted lines
mirpedrol Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Very minor patch release to fix the full size AWS tests and re-run the template
- Remove traces of markdownlint in the template ([#1486](https://github.com/nf-core/tools/pull/1486)
- Remove accidentally added line in `CHANGELOG.md` in the template ([#1487](https://github.com/nf-core/tools/pull/1487))
- Update linting to check that `.editorconfig` is there and `.yamllint.yml` isn't.
- Don't save md5sum for `versions.yml` when running `nf-core modules create-test-yml` ([#1511](https://github.com/nf-core/tools/pull/1511))

## [v2.3.1 - Mercury Vulture Formatting](https://github.com/nf-core/tools/releases/tag/2.3.1) - [2022-03-23]

Expand Down
4 changes: 4 additions & 0 deletions nf_core/modules/test_yml_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,10 @@ def create_test_file_dict(self, results_dir, is_repeat=False):
test_files = []
for root, dir, file in os.walk(results_dir):
for elem in file:
mirpedrol marked this conversation as resolved.
Show resolved Hide resolved
# Check that the file is not versions.yml
if elem = "versions.yml":
ewels marked this conversation as resolved.
Show resolved Hide resolved
continue

elem = os.path.join(root, elem)
test_file = {"path": elem} # add the key here so that it comes first in the dict
# Check that this isn't an empty file
Expand Down