Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #1436

Merged
merged 6 commits into from
Mar 11, 2022
Merged

Fix tests #1436

merged 6 commits into from
Mar 11, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 11, 2022 •
edited
Loading

See #1431 (comment)

Python tests weren't running if python files weren't edited, so this wasn't caught.

Changed python workflow to always run. Need to figure out what the failing test is though.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels changed the base branch from master to dev March 11, 2022 11:00
@nf-core nf-core deleted a comment from github-actions bot Mar 11, 2022
@ewels ewels mentioned this pull request Mar 11, 2022
Merged
4 tasks
@codecov

This comment was marked as resolved.

Sign in to view
sateeshperi
sateeshperi approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@sateeshperi sateeshperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sateeshperi sateeshperi merged commit dc10cc4 into nf-core:dev Mar 11, 2022
@ewels ewels deleted the fix-tests branch March 14, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@sateeshperi sateeshperi sateeshperi approved these changes

Assignees

@JoseEspinosa JoseEspinosa

@drpatelh drpatelh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ewels @maxulysse @FriederikeHanssen @sateeshperi @JoseEspinosa @drpatelh