-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite modules create repo type check. #1391
Conversation
* Use .nf-core.yml file if we can find it, with 'repository_type' key * Traverse parent directories to look for this file, reset target directory if found * Add flag to specify if no .nf-core.yml file available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to update the pipeline template to add the repository_type
flag?
We will definitely need to add this to the modules repo I think.
oof, tests were failing because the repo type check function had been copied + pasted at some point, so there were two copies of it with the same name. Condensed to one, hopefully should all work now 🤞🏻 |
As discussed on Slack, it's a fairly frequent problem for users to struggle with creating modules due to:
main.nf
to nf-core/modules)Here I've introduced more explicit declaration of the repo type:
.nf-core.yml
file if we can find it, withrepository_type
key--repo-type
flag to specify repo type if no.nf-core.yml
file availablePR checklist
CHANGELOG.md
is updateddocs
is updated