-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Julia package support to template #1317
Conversation
Adding in a line to enable support for Julia packages.
Codecov Report
@@ Coverage Diff @@
## dev #1317 +/- ##
=======================================
Coverage 67.33% 67.33%
=======================================
Files 50 50
Lines 5584 5584
=======================================
Hits 3760 3760
Misses 1824 1824 Continue to review full report at Codecov.
|
So if I understand your blog post correctly, this line only really comes into play if used in combination with a custom On the other hand, an extra environment variable in there shouldn't do any harm either. Unless it will break stuff for other (non nf-core official) pipelines that have figured out their own different method for using Julia? But that seems a fairly extreme edge case.. Phil |
Yes, all true. The point is that I didn't find any other Dockerfiles so far that are used in such a setting - mostly "personal" Dockerfiles for interactive work with Julia and no pipelines. I'm also not 100% sure whats the best idea for the future when more people might want to use Julia in Nextflow pipelines - happy also to have a comment in the ENV part and therefore let people know about it? But that might be not the first place people look for something like this, too. Bioconda etc. have not even started packaging Julia packages (and sounding from the discussion there they might never start doing that...), so there is no "community default" as of now. |
Can do either way - maybe having the discusion here already helps some people looking for information ;-) |
Maybe adding it with a comment explaining and linking to your blog post is a good compromise? |
Update with comment
I've added two lines of comments to the ENV description - if you meant it that way? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, LGTM!
Adding in a line to enable support for Julia packages. Of course this is debatable, but there is no default for julia package installation like the ones for R/Python - users wanting to use Julia code with extra dependencies inside a Nextflow pipeline would be required to create a Docker container with the packages installed now at
JULIA_DEPOT_PATH = "/usr/local/share/julia"
to make it work with Nextflow.My blog post is explaining a bit more in detail:
https://apeltzer.github.io/post/03-julia-lang-nextflow
PR checklist
CHANGELOG.md
is updateddocs
is updated