Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update template version of the dumpsoftwareversions module #1281

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Update template version of the dumpsoftwareversions module #1281

merged 2 commits into from
Oct 7, 2021

Conversation

JoseEspinosa
Copy link
Member

As mentioned on this PR on the rnaseq pipeline the dumpsoftwareversions module was updated to correctly report trailing zeros. Here, the template is updated with the new module implementation.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated

@JoseEspinosa JoseEspinosa requested a review from drpatelh October 6, 2021 21:00
drpatelh
drpatelh approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@drpatelh drpatelh merged commit 7ca734b into nf-core:dev Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoseEspinosa @drpatelh