-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add consistency checks between installed modules and modules.json
#1200
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1200 +/- ##
==========================================
- Coverage 70.12% 69.49% -0.63%
==========================================
Files 49 49
Lines 5312 5403 +91
==========================================
+ Hits 3725 3755 +30
- Misses 1587 1648 +61
Continue to review full report at Codecov.
|
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It's going to be tricky reviewing these PRs having not touched the code base for a while and with everything else I am trying to do at the mo but happy to get this in so it can be tested properly :)
Thanks @ErikDanielsson
Thanks for the review @drpatelh! |
Added consistency checks between modules present in pipeline and
modules.json
:modules.json
file we try to reinstall it at the given commit SHAmodules.json
modules.json
we try figure out the correct one using the file contents. If that fails, we continue but warn the user.These checks are run when either
nf-core modules install
ornf-core modules list local
are run. Should resolve #1199.PR checklist
CHANGELOG.md
is updateddocs
is updated