Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Zenodo DOI badge #61

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Added Zenodo DOI badge #61

merged 2 commits into from
Jun 23, 2022

Conversation

praveenraj2018
Copy link
Contributor

Added Zenodo DOI badge for this pipeline

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/rnavar branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @praveenraj2018,

It looks like this pull-request is has been made against the nf-core/rnavar master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/rnavar dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented Jun 23, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 051ad2b

+| ✅ 147 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '1.0.0'
  • readme - README did not have a Nextflow minimum version badge.

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-06-23 09:08:00

@praveenraj2018 praveenraj2018 requested a review from maxulysse June 23, 2022 09:08
@maxulysse
Copy link
Member

Can you do the same PR in dev as well, so that we have it there too?

@maxulysse maxulysse merged commit 222d7a1 into master Jun 23, 2022
@maxulysse maxulysse deleted the praveenraj2018-patch-1 branch June 23, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@praveenraj2018 @maxulysse