Dev -> Master for v3.2 release #657
Conversation
Bump pipeline version to 3.2dev
This script will fail if only one sample is provided as R drops the matrix to a vector if not `drop=FALSE` is given.
Add missing iGenome
Patch use of file append
Fix pipeline if only one sample is provided
Re-write SRA download workflow to accept --ena_metadata_fields parameter
Added stand-alone executable to auto-create samplesheet from a directory of FastQ files
Add salmon_quant_libtype parameter
There was a problem hiding this comment.
Most of @grst comments are on point, and I'm afraid I have very little to add.
I agree that the removing of SRA download could be seen as a major upgrade, but I think this was a minor feature so I think it's still ok to go for a 3.2 release.
| if (params.public_data_ids) { | ||
| include { SRA_DOWNLOAD } from './workflows/sra_download' | ||
| SRA_DOWNLOAD () | ||
| include { RNASEQ } from './workflows/rnaseq' |
There was a problem hiding this comment.
It became a bug now see here 😮
There was a problem hiding this comment.
Yup. Saw that! Fixed, just in the nick of time 😆
|
Think I have addressed all of your comments now @grst! Thanks for the thorough review :) Be awesome if you can create a small PR adding the regex functionality and then we can release. |
Address release review comments
Make samplesheet
|
We good to go now @grst ? Be awesome if you can approve. Sorry, tending to a sick baby so be good to get this out before **** hits the fan again! |
|
Let's go! 💥 |
No description provided.