Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update expansionhunter #502

Merged
merged 4 commits into from
Jan 31, 2024
Merged

update expansionhunter #502

merged 4 commits into from
Jan 31, 2024

Conversation

ramprasadn
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ramprasadn ramprasadn linked an issue Jan 30, 2024 that may be closed by this pull request
Save bam files from exapnsionhunter #493
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit a4b5ee1

+| ✅ 176 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   2 tests had warnings |!
-| ❌   3 tests failed       |-

❌ Test failures:

  • files_unchanged - .github/PULL_REQUEST_TEMPLATE.md does not match the template
  • files_unchanged - docs/images/nf-core-raredisease_logo_light.png does not match the template
  • files_unchanged - docs/images/nf-core-raredisease_logo_dark.png does not match the template

❗ Test warnings:

  • pipeline_todos - TODO string in WorkflowRaredisease.groovy: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml

✅ Tests passed:

Run details

  • nf-core/tools version 2.12
  • Run at 2024-01-31 15:33:00

@ramprasadn ramprasadn marked this pull request as ready for review January 31, 2024 08:23
jemten
jemten approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@jemten jemten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jemten
Copy link
Collaborator

jemten commented Jan 31, 2024

Forgot to add that we should add the new output files to the documentation

@ramprasadn ramprasadn merged commit 3e0b193 into nf-core:dev Jan 31, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemten jemten jemten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save bam files from exapnsionhunter
2 participants
@ramprasadn @jemten