Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add manifest.contributors metadata to nextflow.config #124

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Add manifest.contributors metadata to nextflow.config #124

merged 2 commits into from
Jan 15, 2025

Conversation

fbdtemme
Copy link
Collaborator

Add all current contributors to manifest.contributors

@fbdtemme fbdtemme changed the title Add manifest.contributors metadata Add manifest.contributors metadata to nextflow.config Jan 15, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 8f232ed

+| ✅ 225 tests passed       |+
#| ❔   5 tests were ignored |#
!| ❗   7 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.4.0
  • files_unchanged - LICENSE does not match the template
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.1.1
  • Run at 2025-01-15 10:21:22

ambarrio
ambarrio approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@ambarrio ambarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbdtemme fbdtemme merged commit a228533 into dev Jan 15, 2025
6 checks passed
@fbdtemme fbdtemme deleted the add-contributors branch January 15, 2025 15:17
@fbdtemme fbdtemme mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambarrio ambarrio ambarrio approved these changes

@johandahlberg johandahlberg Awaiting requested review from johandahlberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbdtemme @ambarrio