Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add environment.yml for doubletdetection #6997

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Nov 14, 2024

Follow up to #6897

@edmundmiller edmundmiller requested a review from a team as a code owner November 14, 2024 20:19
@edmundmiller edmundmiller self-assigned this Nov 14, 2024
@edmundmiller edmundmiller requested review from LeonHafner and removed request for a team November 14, 2024 20:21
@SPPearce
Copy link
Contributor

Hey @edmundmiller , what is going on with this PR?

@LeonHafner
Copy link
Contributor

I already had a look at it and tried to fix the container issues but I'm currently lacking time.
I think the problem is that the old seqera container (build page) works, but the new seqera container (build page) seems to have some dependency issues with numpy, despite being built on the same environment file. No idea why it didn't cache but rebuilt it?

The old container uses a different numpy version, but if you set them to a fixed value and build a new container (build page), it will still result in errors, though different ones. The conda environment is facing the same problem as the new containers.

Any ideas how we could rebuild a new container and environment with the exact dependencies used in the old container (the one built 06/2023)?

@LeonHafner LeonHafner requested a review from SPPearce December 16, 2024 15:11
@edmundmiller
Copy link
Contributor Author

Per @LeonHafner, the issue is fixed, so we can merge this. It's just failing #5814

@edmundmiller edmundmiller merged commit 2efd1bc into master Dec 16, 2024
31 of 33 checks passed
@edmundmiller edmundmiller deleted the doubledetection-env branch December 16, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants